Explicitly add the File backend for local storage #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelyatin
reviewed
Feb 7, 2024
fmount
force-pushed
the
fix_glance_local
branch
from
b624bf9 to
34c0cee
Compare
jistr
approved these changes
Feb 7, 2024
Contributor
|
/lgtm |
Local storage is an example where glance is adopted with a dummy backend. While we decide what should be used as base use case, this patch fixes the local backend adoption by adding type:single, otherwise the webhook will deny the deployment, and we explicitly add the file config to avoid unexpected parsing behaviors. Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
fix_glance_local
branch
from
34c0cee to
4149ca9
Compare
eduolivares
pushed a commit
to eduolivares/data-plane-adoption
that referenced
this pull request
Oct 2, 2025
…te-timeouts Set HAProxy timeout to 60 seconds for storage This patch sets the HAProxy timeout to 60 seconds for storage services (Cinder, Glance, and Manila). This way it's in sync with the Apache default timeouts and matches what we have in OSP17. This will be fixed in the operators themselves to have these same defaults, and this patch is compatible with that change. When the operators code is merged and is run by the CI jobs the defaults in the operators will be ignored in favor of the defaults defined in this patch, so we'll want to revert this patch then. These are the PRs that once their code is run on the CI we can revert this PR: openstack-k8s-operators/cinder-operator#396 openstack-k8s-operators/glance-operator#550 openstack-k8s-operators/manila-operator#282 openstack-k8s-operators/openstack-operator#830 Jira: https://issues.redhat.com/browse/OSPRH-7393 Jira: https://issues.redhat.com/browse/OSPRH-7415 Reviewed-by: Andrew Bays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local storage is an example where glance is adopted with a dummy backend.
While we decide what should be used as base use case, this patch fixes the local backend adoption by adding type:single, otherwise the webhook will deny the deployment, and we explicitly add the file config to avoid unexpected parsing behaviors.